Skip to content

new solver: improve instrument annotations #118454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 30, 2023
Merged

new solver: improve instrument annotations #118454

merged 1 commit into from
Nov 30, 2023

Conversation

lcnr
Copy link
Contributor

@lcnr lcnr commented Nov 29, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 29, 2023
@rustbot
Copy link
Collaborator

rustbot commented Nov 29, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Collaborator

bors commented Nov 29, 2023

📌 Commit 0ec2bf3 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2023
@compiler-errors
Copy link
Member

@bors rollup

@lcnr lcnr assigned compiler-errors and unassigned b-naber Nov 29, 2023
@bors
Copy link
Collaborator

bors commented Nov 29, 2023

⌛ Testing commit 0ec2bf3 with merge 79049a9...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023
@bors
Auto merge of rust-lang#118454 - lcnr:overflow-yay, r=compiler-errors
79049a9 
new solver: improve instrument annotations
@bors
Copy link
Collaborator

bors commented Nov 29, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 29, 2023
@compiler-errors
Copy link
Member

@bors treeclosed=100

error parsing HTTP 429 response body: invalid character 'T' looking for beginning of value: "Too Many Requests (HAP429).\n"

@bors retry :(

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 29, 2023
@compiler-errors
Copy link
Member

let's test again

@bors p=101

@bors
Copy link
Collaborator

bors commented Nov 29, 2023

⌛ Testing commit 0ec2bf3 with merge 5c2efcb...

bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 29, 2023
@bors
Auto merge of rust-lang#118454 - lcnr:overflow-yay, r=compiler-errors
5c2efcb 
new solver: improve instrument annotations
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

This was referenced Nov 29, 2023
Merged
Merged
Merged
@RalfJung
Copy link
Member

@bors retry

@bors
Copy link
Collaborator

bors commented Nov 29, 2023

⌛ Testing commit 0ec2bf3 with merge 475f6f8...

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@RalfJung
Copy link
Member

Oh damn sorry. I saw the log-analyzer message and thought it meant the run had failed. But that message was heavily delayed, this was an error from the run before...

@compiler-errors
Copy link
Member

Nah, it was worth checking again. Keeping the tree closed in that case :3

@RalfJung RalfJung mentioned this pull request Nov 29, 2023
Open
@RalfJung
Copy link
Member

RalfJung commented Nov 29, 2023 •
edited
Loading

Yeah I just canceled and restarted a perfectly good run though. (Look just at the bors messages and ignore the log-analyzer. log-analyzer sometimes has large latency leading to confusing interleaving of messages.) Oh well, too late to do anything about it.

@compiler-errors
Copy link
Member

Ohhh I get it. Oh well 🤷 😄

@compiler-errors
Copy link
Member

looks like tree can be opened

@bors treeclosed-

@compiler-errors
Copy link
Member

@bors ping

@bors
Copy link
Collaborator

bors commented Nov 29, 2023

😪 I'm awake I'm awake

@bors
Copy link
Collaborator

bors commented Nov 30, 2023

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing 475f6f8 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 30, 2023
@bors bors merged commit 475f6f8 into rust-lang:master Nov 30, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 30, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (475f6f8): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 3.5% [2.6%, 4.4%] 2
Regressions ❌
(secondary)		 3.9% [3.9%, 3.9%] 1
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -4.7% [-4.7%, -4.7%] 1
All ❌✅ (primary) 3.5% [2.6%, 4.4%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.3% [-2.3%, -2.3%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 673.247s -> 675.01s (0.26%)
Artifact size: 313.38 MiB -> 313.40 MiB (0.01%)

@lcnr lcnr deleted the overflow-yay branch November 30, 2023 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@compiler-errors compiler-errors

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
8 participants
@lcnr @rustbot @compiler-errors @bors @rust-log-analyzer @RalfJung @rust-timer @b-naber